Update Compute 'TestInit` test to use 'threadsafe.Buffer'#1601
Merged
Conversation
rcaril
changed the title
Member
Author
|
The windows test has passed a handful of iterations in this PR without fail (4 passes as of this comment). |
kpfleming
approved these changes
Dec 15, 2025
Member
kpfleming
left a comment
kpfleming
left a comment
There was a problem hiding this comment.
Such a small change but containing so much power :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change summary
This PR eliminates the intermittent behavior of the
TestInitfunction failing on thewindows-latesttest, which was caused by a race condition associated with the CLIyacspin spinner. Replacing the output capture frombytes.Buffertothreadsafe.Bufferensures that race conditions are no longer occur by removing potential unsafe access to the buffer.All Submissions: